cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From runseb <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8893: Fixing script as per the...
Date Wed, 30 Sep 2015 08:13:13 GMT
Github user runseb commented on the pull request:

    https://github.com/apache/cloudstack/pull/871#issuecomment-144322464
  
    @pavanb018 it always helps other folks reviewing to know what you did. For example. 
    Did you just check the Travis green light ? Did you just check the code through github
? Did you pull the patch, apply and compile ? Did you do the build then run the tests. It
may sound obvious to you what you did by giving the copy paste form a test, but writing a
small friendly sentence for the next reviewer will go a long way to help us merge those fixes
as a group.
    
    thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message