cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From resmo <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state is up...
Date Sun, 27 Sep 2015 13:11:23 GMT
Github user resmo commented on the pull request:

    https://github.com/apache/cloudstack/pull/885#issuecomment-143549250
  
    @karuturi @anshul1886 
    So, I 'll checked the handling again and what I see is, it will not work with this one
line change only:
    ~~~
     Date vmStateUpdateTime = instance.getPowerStateUpdateTime();
    ~~~
    because powerState will only be updated to `powerReportMissing` __after__ grace period
handling. Which is too late.
    
    Otherwise we would completely change the logic and move the `updatePowerState` for state
`powerReportMissing` outside the grace period handing. This would be a much bigger change,
for which I can not say if anything else would break.
    
    I am still for my solution in this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message