cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From borisroman <...@git.apache.org>
Subject [GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues
Date Fri, 25 Sep 2015 17:28:09 GMT
Github user borisroman commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/887#discussion_r40454164
  
    --- Diff: server/src/com/cloud/network/firewall/FirewallManagerImpl.java ---
    @@ -426,7 +426,8 @@ public void detectRulesConflict(FirewallRule newRule) throws NetworkRuleConflict
                     // we allow port forwarding rules with the same parameters but different
protocols
                     boolean allowPf =
                         (rule.getPurpose() == Purpose.PortForwarding && newRule.getPurpose()
== Purpose.PortForwarding && !newRule.getProtocol().equalsIgnoreCase(
    -                        rule.getProtocol()));
    +                        rule.getProtocol())) || (rule.getPurpose() == Purpose.Vpn &&
newRule.getPurpose() == Purpose.PortForwarding && !newRule.getProtocol().equalsIgnoreCase(
    +                            rule.getProtocol()));
    --- End diff --
    
    Agree.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message