cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues
Date Fri, 25 Sep 2015 16:45:53 GMT
Github user wilderrodrigues commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/887#discussion_r40449936
  
    --- Diff: server/test/com/cloud/network/firewall/FirewallManagerTest.java ---
    @@ -71,6 +79,7 @@
     //        super.setUp();
     //    }
     
    +    @Ignore("Requires database to be set up")
    --- End diff --
    
    Because it says: "Requires database to be set up"
    
    So I'm assuming that the person who wrote it either did not know how to mock the DB layer
or the ACS is just to messed up to a point where mocking DB stuff is almost impossible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message