cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues
Date Fri, 25 Sep 2015 16:44:50 GMT
Github user wilderrodrigues commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/887#discussion_r40449856
  
    --- Diff: server/test/com/cloud/network/firewall/FirewallManagerTest.java ---
    @@ -52,9 +60,9 @@
     import com.cloud.network.rules.FirewallRuleVO;
     import com.cloud.utils.component.ComponentContext;
     
    -@Ignore("Requires database to be set up")
    -@RunWith(SpringJUnit4ClassRunner.class)
    -@ContextConfiguration(locations = "classpath:/testContext.xml")
    +//@Ignore("Requires database to be set up")
    +@RunWith(MockitoJUnitRunner.class)
    +//@ContextConfiguration(locations = "classpath:/testContext.xml")
    --- End diff --
    
    I don't know. As @remibergsma mentioned, we just got the thing running with 7 PRs.
    
    It's very good to have you looking into it, @borisroman . I really mean it! :) It means
that when those PRs were pushed by the original authors nobody looked at them at all!
    
    Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message