cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wido <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8896: allocated percentage of ...
Date Wed, 23 Sep 2015 12:10:12 GMT
Github user wido commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/873#discussion_r40195709
  
    --- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
    @@ -1736,7 +1737,10 @@ public boolean storagePoolHasEnoughSpace(List<Volume> volumes,
StoragePool pool)
                         allocatedSizeWithtemplate = _capacityMgr.getAllocatedPoolCapacity(poolVO,
tmpl);
                     }
                 }
    -            if (volumeVO.getState() != Volume.State.Ready) {
    +            // A ready state volume is already allocated in a pool. so the asking size
is zero for it.
    +            // In case the volume is moving across pools or is not ready yet, the asking
size has to be computed
    +            s_logger.debug("pool id for the volume with id: " + volumeVO.getId() + "
is: " + volumeVO.getPoolId());
    --- End diff --
    
    Could you make this line a bit more descriptive? To me it doesn't seem like a very useful
line when running in debug mode.
    
    Also, do we want the numeric IDs here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message