cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nlivens <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Date Mon, 21 Sep 2015 12:50:49 GMT
Github user nlivens commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r39966248
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
    @@ -262,15 +260,19 @@ public String getName() {
         public PingCommand getCurrentStatus(long id) {
             if ((_relativePath == null) || (_relativePath.isEmpty()) || (_cmsUserInfo ==
null) || (_cmsUserInfo.length == 0)) {
                 s_logger.error("Failed to ping to Nuage VSD");
    +            _shouldAudit = true;
                 return null;
             }
             try {
                 login();
             } catch (Exception e) {
                 s_logger.error("Failed to ping to Nuage VSD on " + _name + " as user " +
_cmsUserInfo[1] + " Exception " + e.getMessage());
    --- End diff --
    
    During the configuration of this resource, the value of _cmsUserInfo is set to `_cmsUserInfo
= new String[] {CMS_USER_ENTEPRISE_NAME, cmsUser, cmsUserPass};`
    Therefore, this is safe :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message