cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nlivens <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Date Mon, 21 Sep 2015 11:33:30 GMT
Github user nlivens commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r39961184
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
    @@ -454,6 +563,80 @@ protected boolean applyACLRules(Network network, List<? extends
InternalIdentity
         }
     
         @Override
    +    public boolean applyNetworkACLs(Network config, List<? extends NetworkACLItem>
rules) throws ResourceUnavailableException {
    --- End diff --
    
    Since this is an overridden method from a base class, we can not change the return type


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message