cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karuturi <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Cloudstack-8816 some of the events do not...
Date Mon, 21 Sep 2015 11:23:03 GMT
Github user karuturi commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/849#discussion_r39960628
  
    --- Diff: api/src/org/apache/cloudstack/context/CallContext.java ---
    @@ -90,7 +90,13 @@ public void putContextParameter(Object key, Object value) {
         }
     
         public Object getContextParameter(Object key) {
    -        return context.get(key);
    +        Object value = context.get(key);
    +        //check if the value is present in the toString value of the key
    +        //due to a bug in the way we update the key by serializing and deserializing,
it sometimes gets toString value of the key. @see com.cloud.api.ApiAsyncJobDispatcher#runJob
    +        if(value == null ) {
    +            value = context.get(key.toString());
    --- End diff --
    
    key cannot be null. There is a not null check at the only place where it is called ActionEventUtils.publishOnEventBus().
updated the javadoc


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message