cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Date Fri, 18 Sep 2015 22:24:53 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r39907150
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
    @@ -464,4 +517,10 @@ protected void isNuageVspSyncLoaded() throws Exception {
                 throw new Exception(NUAGE_VSP_PLUGIN_ERROR_MESSAGE);
             }
         }
    +
    +    protected void isNuageVspManagerLoaded() throws Exception {
    +        if (!_isNuageVspClientLoaded || _nuageVspManagerClient == null) {
    +            throw new Exception(NUAGE_VSP_PLUGIN_ERROR_MESSAGE);
    --- End diff --
    
    Generally, ``Exception`` should not be thrown. Thrown the specific type of exception that
causes this condition (e.g. ``IllegalStateException``).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message