cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Date Fri, 18 Sep 2015 21:33:52 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r39903493
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManager.java
---
    @@ -19,37 +19,66 @@
     
     package com.cloud.network.manager;
     
    -import java.util.List;
    -
    -import org.apache.cloudstack.framework.config.ConfigKey;
    -import org.apache.cloudstack.framework.config.ConfigKey.Scope;
    -
     import com.cloud.api.commands.AddNuageVspDeviceCmd;
     import com.cloud.api.commands.DeleteNuageVspDeviceCmd;
     import com.cloud.api.commands.ListNuageVspDevicesCmd;
    +import com.cloud.api.commands.UpdateNuageVspDeviceCmd;
     import com.cloud.api.response.NuageVspDeviceResponse;
    +import com.cloud.network.Network;
     import com.cloud.network.NuageVspDeviceVO;
     import com.cloud.utils.component.PluggableService;
    +import org.apache.cloudstack.framework.config.ConfigKey;
    +import org.apache.cloudstack.framework.config.ConfigKey.Scope;
    +
    +import java.util.List;
     
     public interface NuageVspManager extends PluggableService {
     
    -    static final String NUAGE_VPC_OFFERING_NAME = "Default VPC offering with NuageVsp";
    +    public static final String nuageVspSharedNetworkOfferingWithSGServiceName = "DefaultNuageVspSharedNetworkOfferingWithSGService";
     
    -    static final String NUAGE_VPC_OFFERING_DISPLAY_TEXT = "Default VPC offering with
NuageVsp";
    +    public static final String nuageVPCOfferingName = "Nuage VSP VPC Offering";
     
    -    static final ConfigKey<Integer> NuageVspSyncInterval = new ConfigKey<Integer>(Integer.class,
"nuagevsp.sync.interval", "Advanced", "480",
    -            "The interval (in minutes) to wait before running the next synchronization
worker to synchronize the information between CloudStack and NuageVsp", false, Scope.Global,
    -            1);
    +    public static final String nuageVPCOfferingDisplayText = "Nuage VSP VPC Offering";
    --- End diff --
    
    ``public`` modifiers are extraneous on ``public`` interface declarations.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message