cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Date Fri, 18 Sep 2015 20:40:58 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r39898685
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
    @@ -129,6 +145,18 @@
         AgentManager _agentMgr;
         @Inject
         NetworkOfferingDao _ntwkOfferingDao;
    +    @Inject
    +    ConfigurationDao _configDao;
    +    @Inject
    +    NuageVspManager _nuageVspManager;
    +    @Inject
    +    FirewallRulesDao _firewallRulesDao;
    +    @Inject
    +    FirewallRulesCidrsDao _firewallRulesCidrsDao;
    +    @Inject
    +    PhysicalNetworkDao _physicalNetworkDao;
    +    @Inject
    +    NetworkACLItemDao _networkACLItemDao;
     
         @Override
         public boolean applyIps(Network network, List<? extends PublicIpAddress> ipAddress,
Set<Service> service) throws ResourceUnavailableException {
    --- End diff --
    
    This method is incredibly long and performing many different operations.  Decompose into
a smaller private/utility methods and possibly consider some small ValueObjects.  Each of
these methods should have a set of unit tests to verify them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message