cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Date Fri, 18 Sep 2015 20:06:42 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r39895353
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java
---
    @@ -19,31 +19,45 @@
     
     package com.cloud.agent.api.element;
     
    +import com.cloud.agent.api.Command;
    +
     import java.util.List;
     import java.util.Map;
     
    -import com.cloud.agent.api.Command;
    -
     public class ApplyAclRuleVspCommand extends Command {
     
    +    boolean _networkAcl;
         String _networkUuid;
         String _networkDomainUuid;
         String _vpcOrSubnetUuid;
    -    boolean _isL3Network;
    +    String _networkName;
    +    boolean _isL2Network;
         List<Map<String, Object>> _aclRules;
    -    boolean _isVpc;
         long _networkId;
    +    boolean _egressDefaultPolicy;
    +    Boolean _acsIngressAcl;
    +    boolean _networkReset;
    +    String _domainTemplateName;
    --- End diff --
    
    Why aren't these attributes declared ``private``?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message