cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From borisroman <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8688 - default policies for IN...
Date Thu, 17 Sep 2015 16:16:07 GMT
Github user borisroman commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/765#discussion_r39765711
  
    --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
    @@ -414,7 +426,7 @@ def fw_router(self):
             self.fw.append(['', '', '-A NETWORK_STATS -i eth2 -o eth0'])
             self.fw.append(['', '', '-A NETWORK_STATS -o eth2 ! -i eth0 -p tcp'])
             self.fw.append(['', '', '-A NETWORK_STATS -i eth2 ! -o eth0 -p tcp'])
    -
    +        
    --- End diff --
    
    @wilderrodrigues Seems like you hadn't removed the trailing white spaces. Maybe a good
time to remove them when PRing CLOUDSTACK-8878 or CLOUDSTACK-8795? :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message