cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8805: Domains become inactive ...
Date Thu, 17 Sep 2015 12:03:27 GMT
Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/775#issuecomment-141056052
  
    in general: factor out a small chunk of the method into a private method or helper class.
(commit 1)
    then unit test that. (commit 2)
    then apply your fix (commit three) bull's eye (hopefully)
    In your more particular case @nitin-maharana , I think we don't have the test infrastructure
to do it.
    We need to create it. I am not burdonning you with this but if you want to: the replace
call you make is in the sql domain and what we'd need is sql unit stuff.
    
    I am starting to feel my wearyness is ungrounded but those feeling are always dangerous.
A replacement of the replace call in java space could make it more (read easier) testable.
it might have performance ramifications.
    
    that all said; let's discus risk versus priority of this fix. Does anybody have ideas
on this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message