cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sureshanaparti <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8854: Apple Mac OS/X VM get cr...
Date Wed, 16 Sep 2015 12:42:25 GMT
Github user sureshanaparti commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/828#discussion_r39624157
  
    --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java ---
    @@ -598,6 +601,19 @@ public static void setBasicVmConfig(VirtualMachineConfigSpec vmConfig,
int cpuCo
             vmConfig.setGuestId(guestOsIdentifier);
         }
     
    +    public static void addUSBController(VirtualMachineConfigSpec vmConfigSpec) {
    --- End diff --
    
    @sateesh-chodapuneedi all the prepareXyzDevice() methods in VmwareHelper class returns
VirtualDevice. So to be consistent, i think it is better to return a VirtualDevice when preparing
USB controller and this device is added to the device config spec same as other devices.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message