cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Changed variable s_logger to non-static a...
Date Wed, 16 Sep 2015 07:45:45 GMT
Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/778#issuecomment-140658135
  
    All,
    
    Given the current blocker issues we have to fix on master in order to release 4.6.0 and
the fact that those changes don't really improve the current code base, I will :-1:  this
PR and will object if this PR gets 2 LGTMs.
    
    @rafaelweingartner, please have a look at the dev-list in order to see the proposal for
PRs and how they should be created.
    
    In addition, for your students with less experience with Java/Eclipse/Maven/Git, try to
avoid giving them such a huge task.
    
    Cheers,
    Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message