cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhaisaab <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8863: VM doesn't reconnect to ...
Date Wed, 16 Sep 2015 07:03:02 GMT
Github user bhaisaab commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/836#discussion_r39598913
  
    --- Diff: systemvm/patches/debian/config/opt/cloud/bin/vr_cfg.sh ---
    @@ -93,4 +93,16 @@ done < $cfg
     #remove the configuration file, log file should have all the records as well
     rm -f $cfg
     
    +# Flush kernel conntrack table
    +log_it "VR config: Flushing conntrack table"
    +ps cax | grep conntrackd > /dev/null
    +if [ $? -eq 0 ]; then
    --- End diff --
    
    instead of ps <args> | grep, why not use status result and start, like: service
conntrackd status || service conntrackd start (or other commands) etc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message