cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Changed variable s_logger to non-static a...
Date Wed, 16 Sep 2015 06:40:53 GMT
Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/714#issuecomment-140645340
  
    Hi @rafaelweingartner ,
    
    I understood that @pedro-martins went through a hard time checking class by class, but
I would not discuss credits and that kind of stuff here because it could sound like an excuse.
Being pragmatic: the PR is huge, lacks unit/integration tests and did not even compile. We
are all here to help and understand how to get all software/system engineers to commit code
that keeps us, at least, in the same quality level we have now: not decreasing our already
poor coverage.
    
    Concerning your environment: nice you have 4.3.2 in production and test. However, if you
are changing master - 4k lines - it would be extremely nice to have a test environment  to
cover your changes. If building a new test environment would cost too much time, you could
at least have something like:
    
    * 1 VM with mysql and the source code
    * Build your branch on that VM
    * run the integration tests - with the simulator, at least
    * if all goes fine, create the PR
    
    component/test_routers.py
    component/test_vpc_routers.py
    component/test_vpc_vm_life_cycle.py
    smoke/test_vm_life_cycle.py
    
    All instructions about how to run tests and the simulator can be found here: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Validating+check-ins+for+your+local+changes%2C+using+Simulator
    
    If you want to build a DevCloud environment and use it to execute more advanced integration
tests against, please check here: https://cwiki.apache.org/confluence/display/CLOUDSTACK/DevCloud
    
    We are here to help.
    
    Cheers,
    Wilder
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message