cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Replaced all occurences of Charset.forNam...
Date Wed, 16 Sep 2015 06:27:04 GMT
Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/832#issuecomment-140642411
  
    Hi @borisroman 
    
    Few months ago we had a thread on the list to discuss which PR flow we should have in
place in order to increase ACS quality. The idea was:
    
    * Each PR should contain:
      * Jira ticket
      * Proper description of the change: what it fixes / what is the improvement
      * Tests - either Unit or Integration
    
    Except for the unit test part, which is already being covered by the StringUtilsTest class,
the other 2 points are missing in your PR.
    
    Could you please create a ticket and edit the PR description?
    
    Cheers,
    Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message