cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <>
Subject [GitHub] cloudstack pull request: Changed variable s_logger to non-static a...
Date Tue, 15 Sep 2015 20:26:50 GMT
Github user rafaelweingartner commented on the pull request:
    I do agree with you that removing duplicated code, reducing cyclomatic complexity and
writing test case is much better. However, those tasks require certain programing skills and
knowledge of the code. I have interns that have never worked with Java, spring*, web applications
and Eclipse/Netbeans. Therefore, I am starting introducing simple and pretty easy tasks, so
they can get comfortable working on a huge project such as ACS. It takes a while to get used
to working with tools such as Eclipse, Maven and Git. 
    We are at the very beginning of my thesis. Most of them are not ready to start writing
TDDs and refactoring methods. The ones that are, we already did some pretty interesting PRs:
#560, #700 and #762.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message