cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Changed variable s_logger to non-static a...
Date Tue, 15 Sep 2015 18:29:32 GMT
Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/778#issuecomment-140491359
  
    Actually, the ticket is as simple as that. 
    
    It was just an exercise to an intern that is working with me in my thesis. We are doing
few very small cleans and changes in ACS code to teach some coding skills to some interns.
Thus, we found pretty bothering to code sometimes, we were coding you start to write “log”
and hit ctrl+space bar and nothing showed up, the same happens in classes that use the “_”
to start variable names. We know that s_something is an ACS standard for static variables,
but we thought that the name logger would be better. 
    
    That was a pretty interesting proposal, because we could get to know a little better the
ACS code, and found some others small things we could change to make the coding more pleasant.
For instance, we are planning a PR removing the “@Local” from all classes of ComponenteLifeCycleBase,
hence they all are either spring beans or manually instantiated.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message