cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Changed variable s_logger to non-static a...
Date Tue, 15 Sep 2015 11:50:28 GMT
Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/778#issuecomment-140366106
  
    @karuturi @remibergsma @rafaelweingartner @DaanHoogland @miguelaferreira 
    
    Please, before proceeding with this PR see my comments on the previous (#714) one.
    
    We would like to hear what is the problem with the current approach before we get this
change in. And before LGTM it, please make sure that at least the following tests are executed:
    
    test_routers.py
    test_vm_life_cycle.py
    test_vpc_routers.py
    test_vpc_routers_nics.py
    test_reset_vm_on_reboot.py
    
    Also, this branch branch cannot be automatically merged. It has conflicts! It will be
a nightmare to get it through.
    
    Cheers,
    Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message