cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Changed variable s_logger to non-static a...
Date Tue, 15 Sep 2015 11:35:23 GMT
Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/714#issuecomment-140360164
  
    @mike-tutkowski @DaanHoogland @karuturi @miguelaferreira @rafaelweingartner @pedro-martins

    
    First of all let me just get one thing clear: Rafael mentioned that he has a script that
changes the Java files automatically. Did I read it right? If so, why doesn't this script
also compile the code with a simple Maven run after the changes?
    
    We have been suffering from things that simply break and are difficult to track because
PRs are not properly reviewed/tested. In this particular case, how is possible to get 2 LGTM
without even compiling the project locally?
    
    Cheers,
    Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message