cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Quota
Date Tue, 15 Sep 2015 04:02:14 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/768#discussion_r39472668
  
    --- Diff: usage/src/com/cloud/usage/UsageManagerImpl.java ---
    @@ -373,6 +381,26 @@ protected void runInContextInternal() {
                 }
     
                 parse(job, startDate, endDate);
    +            if (_runQuota){
    +                try {
    +                    _quotaManager.calculateQuotaUsage();
    +                }
    +                catch (Exception e){
    +                    s_logger.fatal("Exception received while calculating quota " + e.getMessage());
    +                    if (s_logger.isDebugEnabled()){
    +                        e.printStackTrace();
    +                    }
    +                }
    +                try {
    +                    _alertManager.checkAndSendQuotaAlertEmails();
    +                    _alertManager.sendMonthlyStatement(new Date());
    +                } catch (Exception e) {
    +                    s_logger.fatal("Exception received while sending alerts " + e.getMessage());
    --- End diff --
    
    Why are we logging to ``FATAL`` instead of ``ERROR``?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message