cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From miguelaferreira <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Notify listeners when a host has been add...
Date Mon, 14 Sep 2015 14:21:19 GMT
Github user miguelaferreira commented on the pull request:

    https://github.com/apache/cloudstack/pull/816#issuecomment-140095795
  
    Hi @mike-tutkowski 
    
    Thanks for being open about removing the commented-out code. IMHO (and not just mine btw)
commented-out code poses a serious risk for maintainability. I'll be happy to dive in deeper
on the topic if you would like to. Over beers would be the best setting :)
    
    Regarding the unit tests, I cannot make any time this week since I'm already behind schedule
for completing my sprint. But I will for sure reserve time next sprint (starting on Monday),
to write some unit tests for the code changes in this PR. We can then discuss how to make
the test suite more complete.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message