cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mike-tutkowski <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Notify listeners when a host has been add...
Date Mon, 14 Sep 2015 13:06:43 GMT
Github user mike-tutkowski commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/816#discussion_r39390601
  
    --- Diff: server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
---
    @@ -1971,7 +1971,7 @@ protected void finalizeNetworkRulesForNetwork(final Commands cmds,
final DomainR
         }
     
         private void createDefaultEgressFirewallRule(final List<FirewallRule> rules,
final long networkId) {
    -        String systemRule = null;
    +        // String systemRule = null;
    --- End diff --
    
    While making changes in this file, I noticed that Eclipse was pointing out that the variable
systemRule was not in use. Instead of removing the entire line, I just commented it out in
case someone later wanted to easily resume making use of this variable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message