cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8645: Improve logging of RBD f...
Date Mon, 14 Sep 2015 12:46:13 GMT
Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/821#discussion_r39388787
  
    --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
---
    @@ -877,8 +877,8 @@ public boolean deletePhysicalDisk(String uuid, KVMStoragePool pool,
Storage.Imag
                     rbd.close(image);
                     r.ioCtxDestroy(io);
     
    -                s_logger.debug("Succesfully unprotected and removed any snapshots of
" + pool.getSourceDir() + "/" + uuid +
    -                        " Continuing to remove the RBD image");
    +                s_logger.info("Succesfully unprotected and removed all snapshots " +
snaps.size() + " of " + pool.getSourceDir() + "/" + uuid +
    --- End diff --
    
    This is going to read something like "Succesfully unprotected and removed all snapshots
5 of /<somepath>/<some uuid> Continuing to remove the RBD image", in the logs.
the part "all snapshots # of ..." seems not what you'd want to read. How about "Succesfully
unprotected and removed any remaining snapshots (counting " + snaps.size() + ") of " + ...?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message