cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karuturi <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8827: Move the VM snapshots st...
Date Mon, 14 Sep 2015 08:45:17 GMT
Github user karuturi commented on the pull request:

    https://github.com/apache/cloudstack/pull/793#issuecomment-140003171
  
    @anshul1886 I do not agree to your statement and hence I already tried to explain what
you can test in this piece of code. If you still dont get it(or dont want to understand it)
I cannot explain. 
     I really dont understand why you dont see a value in unittests. I dont want to explain
the benefits of unit testing here (I neither have time nor do I have belief that you will
understand). 
    
    Please add a marvin test on what you are achieving by this change. As much as possible,
we need an automated way to test new code. 
    
    Also, add information what tests you already performed to ensure the code works.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message