cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From miguelaferreira <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Notify listeners when a host has been add...
Date Mon, 14 Sep 2015 07:35:50 GMT
Github user miguelaferreira commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/816#discussion_r39366912
  
    --- Diff: server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
---
    @@ -1589,8 +1589,8 @@ protected StringBuilder createGuestBootLoadArgs(final NicProfile
guestNic, final
         protected StringBuilder createRedundantRouterArgs(final NicProfile nic, final DomainRouterVO
router) {
             final StringBuilder buf = new StringBuilder();
     
    -        final long networkId = nic.getNetworkId();
    -        final NetworkVO network = _networkDao.findById(networkId);
    +        // final long networkId = nic.getNetworkId();
    --- End diff --
    
    Why the commented out code?
    
    (next line too)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message