cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From miguelaferreira <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Notify listeners when a host has been add...
Date Mon, 14 Sep 2015 07:33:53 GMT
Github user miguelaferreira commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/816#discussion_r39366792
  
    --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
    @@ -3327,7 +3330,7 @@ private Answer execute(MigrateVolumeCommand cmd) {
                 // Consolidate VM disks.
                 // In case of a linked clone VM, if VM's disks are not consolidated,
                 // further volume operations on the ROOT volume such as volume snapshot etc.
will result in DB inconsistencies.
    -            String apiVersion = HypervisorHostHelper.getVcenterApiVersion(vmMo.getContext());
    +            // String apiVersion = HypervisorHostHelper.getVcenterApiVersion(vmMo.getContext());
    --- End diff --
    
    Why the commented out code?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message