cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From remibergsma <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8625: Systemd profile for Clou...
Date Sun, 13 Sep 2015 18:44:08 GMT
Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/813#issuecomment-139907185
  
    @wido In order to get it to work on CentOS 7 I had to patch it like this. You may want
to add it to the PR:
    
    ```
    diff --git a/packaging/centos7/cloud.spec b/packaging/centos7/cloud.spec
    index 0ecc406..2028981 100644
    --- a/packaging/centos7/cloud.spec
    +++ b/packaging/centos7/cloud.spec
    @@ -488,7 +488,8 @@ fi
     %attr(0755,root,root) %{_bindir}/%{name}-setup-agent
     %attr(0755,root,root) %{_bindir}/%{name}-agent-upgrade
     %attr(0755,root,root) %{_bindir}/%{name}-ssh
    -%attr(0755,root,root) %{_sysconfdir}/init.d/%{name}-agent
    +%attr(0644,root,root) %{_unitdir}/%{name}-agent.service
    +%attr(0755,root,root) /usr/libexec/cloudstack/cloudstack-agent-systemd-wrapper.sh
     %attr(0644,root,root) %{_sysconfdir}/profile.d/%{name}-agent-profile.sh
     %attr(0755,root,root) %{_datadir}/%{name}-common/scripts/network/cisco
     %config(noreplace) %{_sysconfdir}/%{name}/agent
    ```
    
    Tested it on CentOS 7.1 KVM box and the `systemd` profile works great! If you update the
PR with the above patch (or something with the same result) I'll give you my LGTM :-)
    
    Thanks, Remi


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message