cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ashwinswaroop <...@git.apache.org>
Subject [GitHub] cloudstack pull request: This is the fix for the JIRA issue CLOUDS...
Date Sat, 12 Sep 2015 02:29:39 GMT
Github user ashwinswaroop commented on the pull request:

    https://github.com/apache/cloudstack/pull/810#issuecomment-139703362
  
    Okay that makes sense. I went through the entire project and found only one caller of
setStartPort and setEndPort which was from the relevant class(Firewall Response). There were
others, but they were referring to a different class. The relevant caller took an argument
of the form x.toString previously, but now since I changed the setter definition and the variable
types to Integer, I removed the .toString part since it was already an Integer being converted
to a String. There was no getter definition at all in FirewallResponse.java. Should I go ahead
and commit? Also, in what way should I adjust the comments on my commit like you mentioned?

    Thanks for the help!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message