cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bvbharatk <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8799 fixed the defalut routes
Date Fri, 11 Sep 2015 14:18:41 GMT
Github user bvbharatk commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/784#discussion_r39275218
  
    --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
    @@ -95,9 +95,25 @@ def get_control_if(self):
                     return ip
             return None
     
    +    def check_if_link_exists(self,dev):
    +        cmd="ip link show dev %s"%dev
    +        result=CsHelper.execute(cmd)
    +        if(len(result)!=0):
    +           return True
    +        else:
    +           return False
    +
    +    def check_if_link_up(self,dev):
    +        cmd="ip link show dev %s | tr '\n' ' ' | cut -d ' ' -f 9"%dev
    --- End diff --
    
    Hi, 
    we have used the subprocess command to find the state of the device in two more places.
I have created a improvement ticket(CLOUDSTACK-8837) to track this. I will work on this later,
until then 
    i guess the current changes will do.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message