cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8820: Showing error when try t...
Date Fri, 11 Sep 2015 12:16:08 GMT
Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/806#discussion_r39265018
  
    --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java ---
    @@ -152,13 +152,26 @@ public void connect(String url, String userName, String password)
throws Excepti
             @SuppressWarnings("unchecked")
             Map<String, List<String>> headers = (Map<String, List<String>>)((BindingProvider)vimPort).getResponseContext().get(MessageContext.HTTP_RESPONSE_HEADERS);
             List<String> cookies = headers.get("Set-cookie");
    +
    +        vimPort.login(serviceContent.getSessionManager(), userName, password, null);
    +
    +        if (cookies == null) {
    +            @SuppressWarnings("unchecked")
    --- End diff --
    
    why suppress? please add a comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message