cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karuturi <>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...
Date Tue, 08 Sep 2015 12:03:43 GMT
Github user karuturi commented on a diff in the pull request:
    --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/
    @@ -4663,7 +4663,7 @@ private VirtualMachineGuestOsIdentifier translateGuestOsIdentifier(String
             String instanceNameCustomField = "value[" + key + "]";
             ObjectContent[] ocs =
    -                hyperHost.getVmPropertiesOnHyperHost(new String[] {"name", "summary.config.numCpu",
"summary.quickStats.overallCpuUsage", instanceNameCustomField});
    +                hyperHost.getVmPropertiesOnHyperHost(new String[] {"name", "summary.config.numCpu",
    --- End diff --
    Can you make them constants and reuse the constants in L4685?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message