cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karuturi <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...
Date Tue, 08 Sep 2015 12:00:48 GMT
Github user karuturi commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/780#discussion_r38916972
  
    --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
    @@ -2981,11 +2985,16 @@ public VmStatsEntry getVmStat(final Connect conn, final String
vmName) throws Li
             try {
                 dm = getDomain(conn, vmName);
                 final DomainInfo info = dm.getInfo();
    +            final MemoryStatistic[] mems = dm.memoryStats(2);
    --- End diff --
    
    What does 2 mean? Can you use a constant and probably add a comment?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message