cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karuturi <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...
Date Fri, 04 Sep 2015 08:45:08 GMT
Github user karuturi commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/755#discussion_r38732126
  
    --- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
    @@ -2177,6 +2173,7 @@ private UserAccount getUserAccount(String username, String password,
Long domain
                 if (domain != null) {
                     domainName = domain.getName();
                 }
    +            userAccount = _userAccountDao.getUserAccount(username, domainId);
    --- End diff --
    
    If the authenticator returns true without a user in cloudstack in DB, it will still fail.
It only happens at a later stage. There are no new assumptions here. It will continue to work
as earlier. If its not that would be a bug. I do not see any issue when running this either
from the test cases or manually. if you see any issue report it and it can be addressed. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message