cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From securityvoodoo <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8678: Reserve RAM for KVM host...
Date Tue, 01 Sep 2015 15:57:33 GMT
Github user securityvoodoo commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/766#discussion_r38436231
  
    --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
    @@ -258,7 +258,7 @@
     
         private String _updateHostPasswdPath;
     
    -    private int _dom0MinMem;
    +    private long _dom0MinMem;
    --- End diff --
    
    I see no reason not to default it to something sane.
    Wido - 
    The way it is setup right now, admins would not be able to change it to something lower
than whatever we default to unless still greater than 768mb or 10% of system ram.  At least
not by specifying it via the host.reserved.mem.mb property.  That being said, the default
should be greater than 768mb.  A 1G default sounds sane to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message