cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karuturi <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...
Date Tue, 01 Sep 2015 12:03:24 GMT
Github user karuturi commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/755#discussion_r38410923
  
    --- Diff: setup/db/db/schema-452to460.sql ---
    @@ -399,3 +399,14 @@ CREATE TABLE `cloud`.`external_bigswitch_bcf_devices` (
       CONSTRAINT `fk_external_bigswitch_bcf_devices__physical_network_id` FOREIGN KEY (`physical_network_id`)
REFERENCES `physical_network`(`id`) ON DELETE CASCADE
     ) ENGINE=InnoDB DEFAULT CHARSET=utf8;
     
    +CREATE TABLE `cloud`.`ldap_trust_map` (
    +  `id` int unsigned NOT NULL AUTO_INCREMENT,
    --- End diff --
    
    I definitely do not want to rename domain-id to id and make it primary. its easier and
convenient to have a surrogate id.
    It helps me in joins and foreign keys which may be required. It will also help in normalizations
or any data structure changes in futures.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message