cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8688 - default policies for IN...
Date Tue, 01 Sep 2015 10:19:43 GMT
Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/765#issuecomment-136664670
  
    Hi @miguelaferreira 
    
    Okay for the Marvin test, but then it will make the thing wait for another day, at least.
Which is fine, but I hope people LGTM it afterwards. I'm worried about the lack of reviews/tests
by reviewers on PRs.
    
    Concerning the unit test, I won't add it because I want to refactor the code as a project
and have it done in a way that we can add tests and refactor, as it was done with other components.
I know it could be done in a way where I could refactor just 1 method, add a tests and push
it. However, I do not want to mix styles in the Python code.
    
    By styles I mean: the way it was developed and the way I would have developed it. So,
mixing styles by refactoring 1 method to add 1 test will not really improve it. Once we release
4.6, and if that okay with the team, I, we, will work on the python refactor.
    
    Cheers,
    Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message