cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From koushik-das <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...
Date Tue, 01 Sep 2015 08:44:39 GMT
Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/755#discussion_r38397126
  
    --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
    @@ -189,6 +194,21 @@ public LdapUser getUser(final String username) throws NoLdapUserMatchingQueryExc
         }
     
         @Override
    +    public LdapUser getUser(final String username, final String type, final String name)
throws NoLdapUserMatchingQueryException {
    +        LdapContext context = null;
    +        try {
    +            context = _ldapContextFactory.createBindContext();
    +            final String escapedUsername = LdapUtils.escapeLDAPSearchFilter(username);
    +            return _ldapUserManagerFactory.getInstance(_ldapConfiguration.getLdapProvider()).getUser(escapedUsername,
type, name, context);
    +        } catch (NamingException | IOException e) {
    +            s_logger.debug("ldap Exception: ",e);
    +            throw new NoLdapUserMatchingQueryException("No Ldap User found for username:
"+username + "name: " + name + "of type" + type);
    --- End diff --
    
    nit-pick - format the string to have spaces


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message