cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8678: Reserve RAM for KVM host...
Date Tue, 01 Sep 2015 08:15:30 GMT
Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/766#discussion_r38394939
  
    --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
    @@ -258,7 +258,7 @@
     
         private String _updateHostPasswdPath;
     
    -    private int _dom0MinMem;
    +    private long _dom0MinMem;
    --- End diff --
    
    I think we need to initialize to a reasonable default or 0L. Not sure if it is possible
by installation but otherwise the properties file might be corrupted or empty.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message