cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karuturi <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...
Date Tue, 01 Sep 2015 04:07:20 GMT
Github user karuturi commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/755#discussion_r38384124
  
    --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
    @@ -243,4 +263,22 @@ public boolean isLdapEnabled() {
                 closeContext(context);
             }
         }
    +
    +    @Override
    +    public LinkDomainToLdapResponse linkDomainToLdap(Long domainId, String type, String
name, short accountType) {
    +        Validate.notNull(type, "type cannot be null. It should either be GROUP or OU");
    --- End diff --
    
    it fails when an enum is created. check the next few lines and the test case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message