Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 422151876F for ; Sun, 2 Aug 2015 13:16:31 +0000 (UTC) Received: (qmail 46513 invoked by uid 500); 2 Aug 2015 13:16:30 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 46451 invoked by uid 500); 2 Aug 2015 13:16:30 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 46439 invoked by uid 99); 2 Aug 2015 13:16:30 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 02 Aug 2015 13:16:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 2F64EC0CB0 for ; Sun, 2 Aug 2015 13:16:30 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.12 X-Spam-Level: X-Spam-Status: No, score=-0.12 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id plOk5QMGkQ4s for ; Sun, 2 Aug 2015 13:16:24 +0000 (UTC) Received: from mail-la0-f43.google.com (mail-la0-f43.google.com [209.85.215.43]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with ESMTPS id 5CC3543DF2 for ; Sun, 2 Aug 2015 13:16:24 +0000 (UTC) Received: by lacct8 with SMTP id ct8so35643981lac.2 for ; Sun, 02 Aug 2015 06:16:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:content-type; bh=w96oiAmsSTz/eTXM0PB28F9PCWpS6n/ht5+KvLj0hYQ=; b=aICZps6k6/CCax/nR94SdS1OzJzy5en/EnXDt7pcZVeXwV5e1gU4GI8PJOClxK2jgM FJNuv0cWbZW1UBsZeYp1rLRf+lUSklnqOkVd9lKn4fcztfCYI2KHEchBVqLUMmOdoIHZ e7lRcPPt6P4VNDpXN4oN27JHVYpO5ml+ZGljLKFmM7W3YDRmOzDYfw9HfbKSqN79CtRr m5lllUBfoji8kH5yIXAkb+OuYRdazF8yaTwPU23rpqn9LgEUVp1wywL0/QZg6O6yN7iY nsbaCN3XrcvA3i1EImg4mjarGYKnsdJ3Q7QsutwY1TCUvbzw3cVVuoRgI0xkqwiplORO Utkw== X-Received: by 10.152.18.137 with SMTP id w9mr12211732lad.23.1438521383243; Sun, 02 Aug 2015 06:16:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.112.181.101 with HTTP; Sun, 2 Aug 2015 06:16:03 -0700 (PDT) From: Daan Hoogland Date: Sun, 2 Aug 2015 15:16:03 +0200 Message-ID: Subject: LGTMs or review critic please To: dev Content-Type: text/plain; charset=UTF-8 I have some trivial changes that deal with ignored exceptions and resource leaks and such, Can I have some feedback on https://github.com/apache/cloudstack/pull/649 https://github.com/apache/cloudstack/pull/604 https://github.com/apache/cloudstack/pull/603 -- Daan