Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: miguelaferreira <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-754-cloudstack@git.apache.org>
In-Reply-To: <git-pr-754-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8762: Check to confirm
 disk ac...
Content-Type: text/plain
Message-Id: <20150827120006.58997E7E32@git1-us-west.apache.org>
Date: Thu, 27 Aug 2015 12:00:06 +0000 (UTC)

Github user miguelaferreira commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/754#discussion_r38087198
  
    --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java ---
    @@ -3923,6 +3944,17 @@ public int compare(DiskTO arg0, DiskTO arg1) {
                     volPath = physicalDisk.getPath();
                 }
     
    +            // check for disk activity, if detected we should exit because vm is running elsewhere
    --- End diff --
    
    Wouldn't this block best be refactored into a separate method?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---