Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: bhaisaab <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-673-cloudstack@git.apache.org>
In-Reply-To: <git-pr-673-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting
 details of...
Content-Type: text/plain
Message-Id: <20150826102658.BA751DFE80@git1-us-west.apache.org>
Date: Wed, 26 Aug 2015 10:26:58 +0000 (UTC)

Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/673#issuecomment-134936210
  
    @anshul1886 the only concern here is that this sort of breaks the API behaviour as in the past the details would set details (removing old details).
    
    LGTM; we can merge once anyone else can review/test this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---