Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: jburwell <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-689-cloudstack@git.apache.org>
In-Reply-To: <git-pr-689-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: Quota master
Content-Type: text/plain
Message-Id: <20150826062220.CFA62E03E6@git1-us-west.apache.org>
Date: Wed, 26 Aug 2015 06:22:20 +0000 (UTC)

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/689#discussion_r37949568
  
    --- Diff: server/src/com/cloud/api/dispatch/ParamProcessWorker.java ---
    @@ -294,6 +294,14 @@ private void setFieldValue(final Field field, final BaseCmd cmdObj, final Object
                         field.set(cmdObj, Float.valueOf(paramObj.toString()));
                     }
                     break;
    +            case DOUBLE:
    +                // Assuming that the parameters have been checked for required before now,
    +                // we ignore blank or null values and defer to the command to set a default
    +                // value for optional parameters ...
    +                if (paramObj != null && isNotBlank(paramObj.toString())) {
    --- End diff --
    
    Consider using ``com.google.common.base.Strings#isNullorEmpty`` method which consolidates the null and blank checks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---