Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 93A7718764 for ; Mon, 24 Aug 2015 08:23:46 +0000 (UTC) Received: (qmail 72326 invoked by uid 500); 24 Aug 2015 08:23:46 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 72271 invoked by uid 500); 24 Aug 2015 08:23:45 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 71988 invoked by uid 99); 24 Aug 2015 08:23:45 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Aug 2015 08:23:45 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 8871BDFE1D; Mon, 24 Aug 2015 08:23:45 +0000 (UTC) From: DaanHoogland To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8754: VM migration triggered b... Content-Type: text/plain Message-Id: <20150824082345.8871BDFE1D@git1-us-west.apache.org> Date: Mon, 24 Aug 2015 08:23:45 +0000 (UTC) Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/725#issuecomment-134089286 @kishankavala a trivial test is better then none. for better tests, a jira ticket can be created and comments in the test class can be added. that said LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---