Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: jburwell <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-689-cloudstack@git.apache.org>
In-Reply-To: <git-pr-689-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: Quota master
Content-Type: text/plain
Message-Id: <20150821120739.9CF47E0102@git1-us-west.apache.org>
Date: Fri, 21 Aug 2015 12:07:39 +0000 (UTC)

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/689#discussion_r37628117
  
    --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java ---
    @@ -0,0 +1,419 @@
    +//Licensed to the Apache Software Foundation (ASF) under one
    +//or more contributor license agreements.  See the NOTICE file
    +//distributed with this work for additional information
    +//regarding copyright ownership.  The ASF licenses this file
    +//to you under the Apache License, Version 2.0 (the
    +//"License"); you may not use this file except in compliance
    +//with the License.  You may obtain a copy of the License at
    +//
    +//http://www.apache.org/licenses/LICENSE-2.0
    +//
    +//Unless required by applicable law or agreed to in writing,
    +//software distributed under the License is distributed on an
    +//"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +//KIND, either express or implied.  See the License for the
    +//specific language governing permissions and limitations
    +//under the License.
    +package org.apache.cloudstack.api.response;
    +
    +import com.cloud.exception.InvalidParameterValueException;
    +import com.cloud.user.Account;
    +import com.cloud.user.AccountVO;
    +import com.cloud.user.User;
    +import com.cloud.user.dao.AccountDao;
    +import com.cloud.user.dao.UserDao;
    +import com.cloud.utils.db.TransactionLegacy;
    +
    +import org.apache.cloudstack.api.command.QuotaBalanceCmd;
    +import org.apache.cloudstack.api.command.QuotaEmailTemplateListCmd;
    +import org.apache.cloudstack.api.command.QuotaEmailTemplateUpdateCmd;
    +import org.apache.cloudstack.api.command.QuotaStatementCmd;
    +import org.apache.cloudstack.api.command.QuotaTariffListCmd;
    +import org.apache.cloudstack.api.command.QuotaTariffUpdateCmd;
    +import org.apache.cloudstack.quota.QuotaService;
    +import org.apache.cloudstack.quota.constant.QuotaConfig;
    +import org.apache.cloudstack.quota.constant.QuotaTypes;
    +import org.apache.cloudstack.quota.dao.QuotaBalanceDao;
    +import org.apache.cloudstack.quota.dao.QuotaCreditsDao;
    +import org.apache.cloudstack.quota.dao.QuotaEmailTemplatesDao;
    +import org.apache.cloudstack.quota.dao.QuotaTariffDao;
    +import org.apache.cloudstack.quota.vo.QuotaBalanceVO;
    +import org.apache.cloudstack.quota.vo.QuotaCreditsVO;
    +import org.apache.cloudstack.quota.vo.QuotaEmailTemplatesVO;
    +import org.apache.cloudstack.quota.vo.QuotaTariffVO;
    +import org.apache.cloudstack.quota.vo.QuotaUsageVO;
    +import org.apache.cloudstack.region.RegionManager;
    +import org.apache.commons.lang.StringEscapeUtils;
    +import org.apache.log4j.Logger;
    +import org.springframework.stereotype.Component;
    +
    +import javax.ejb.Local;
    +import javax.inject.Inject;
    +
    +import java.math.BigDecimal;
    +import java.util.ArrayList;
    +import java.util.Calendar;
    +import java.util.Collections;
    +import java.util.Comparator;
    +import java.util.Date;
    +import java.util.HashMap;
    +import java.util.Iterator;
    +import java.util.List;
    +
    +@Component
    +@Local(value = QuotaResponseBuilderImpl.class)
    +public class QuotaResponseBuilderImpl implements QuotaResponseBuilder {
    +    private static final Logger s_logger = Logger.getLogger(QuotaResponseBuilderImpl.class.getName());
    +
    +    @Inject
    +    private QuotaTariffDao _quotaTariffDao;
    +    @Inject
    +    private QuotaBalanceDao _quotaBalanceDao;
    +    @Inject
    +    private QuotaCreditsDao _quotaCreditsDao;
    +    @Inject
    +    private QuotaEmailTemplatesDao _quotaEmailTemplateDao;
    +
    +    @Inject
    +    private UserDao _userDao;
    +    @Inject
    +    private QuotaService _quotaService;
    +    @Inject
    +    AccountDao _accountDao;
    +    @Inject
    +    private RegionManager _regionMgr;
    +
    +    @Override
    +    public QuotaTariffResponse createQuotaTariffResponse(QuotaTariffVO tariff) {
    +        final QuotaTariffResponse response = new QuotaTariffResponse();
    +        response.setUsageType(tariff.getUsageType());
    +        response.setUsageName(tariff.getUsageName());
    +        response.setUsageUnit(tariff.getUsageUnit());
    +        response.setUsageDiscriminator(tariff.getUsageDiscriminator());
    +        response.setTariffValue(tariff.getCurrencyValue());
    +        response.setEffectiveOn(tariff.getEffectiveOn());
    +        response.setDescription(tariff.getDescription());
    +        response.setCurrency(QuotaConfig.QuotaCurrencySymbol.value());
    +        return response;
    +    }
    +
    +    @Override
    +    public QuotaBalanceResponse createQuotaBalanceResponse(List<QuotaBalanceVO> quotaBalance, Date startDate, Date endDate) {
    +        if (quotaBalance.size() == 0) {
    --- End diff --
    
    Findbugs is a static analysis tool that finds NPE conditions based on the flow expressed by the code configuration provided.  While all null dereferences it identifies are valid, it cannot identify all potential null dereferences because the JAR may be used in another, unevaluated context where a null reference is passed.  Therefore, static analysis is not a substitute for defensive programming best practice, and all de-referenced parameters should be defensively checked to be non-null.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---